Re: [PATCH 1/3] perf, core: Introduce attrs to count in either hostor guest mode

From: Ingo Molnar
Date: Wed May 11 2011 - 13:23:20 EST



* Avi Kivity <avi@xxxxxxxxxx> wrote:

> On 05/11/2011 04:49 PM, Peter Zijlstra wrote:
> >On Wed, 2011-05-11 at 14:45 +0300, Avi Kivity wrote:
> >> Well, actually, that depends on the meaning of exclude_hv.
> >
> >exclude_hv is for when the host is a guest and we don't wish to sample
> >the host's host etc. PPC introduced this because ppc-linux runs as a
> >guest of the 'firmware' and not on the native hardware.
>
> Okay. A comment is needed there to explain the differences then.

Yeah.

Also, the flags are named in a way to make the default zero value the most
inclusive option. So we do not have include_guest but exclude_guest, etc.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/