Re: [PATCH v3] mfd: Add ASIC3 LED support

[Samuel Ortiz]

Hi Paul,

On Mon, May 09, 2011 at 09:03:49PM +0000, Paul Parsons wrote:
> Add LED support for the HTC ASIC3. Underlying support is provided by the mfd/asic3 and leds/leds-asic3 drivers. An example configuration is provided by the pxa/hx4700 platform.
>
Good. I had a pending email requesting that you push the asic3_led pointer as
a platform_data pointer. By the way, it's quite handy when people expose the
changes they added between Vn and Vn+1.
 
The code looks fine now, but I'd prefer to get 2 separate patches for that:
1 for the LED driver and the asic3.h changes and a second one for the asic3.c
changes. I'll merge both at the same time.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/