Re: [PATCH 1/4] mm: Remove dependency on CONFIG_FLATMEM from online_page()
From: Daniel Kiper
Date: Mon May 16 2011 - 04:00:45 EST
On Thu, May 12, 2011 at 12:26:22PM -0700, David Rientjes wrote:
> On Thu, 12 May 2011, Daniel Kiper wrote:
> > > > Memory hotplug code strictly depends on CONFIG_SPARSEMEM.
> > > > It means that code depending on CONFIG_FLATMEM in online_page()
> > > > is never compiled. Remove it because it is not needed anymore.
> > > >
> > > > Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx>
> > >
> > > The code you're patching depends on CONFIG_MEMORY_HOTPLUG_SPARSE, so this
> > > is valid. The changelog should be updated to reflect that, however.
> > >
> > > Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
> > No problem, however, this bundle of patches was added to the -mm tree.
> > In this situation should I repost whole bundle with relevant changes
> > or post only those two patches requested by you ??? For which tree
> > should I prepare new version of patches ???
> No, I would just reply to the email notification you received when the
> patch went into -mm saying that the changelog should be adjusted to read
> something like
> online_pages() is only compiled for CONFIG_MEMORY_HOTPLUG_SPARSE,
> so there is no need to support CONFIG_FLATMEM code within it.
> This patch removes code that is never used.
Please look into attachments.
If you have any questions please drop me a line.