Re: getter PTRACE_GETSIGINFO should not modify anything [Re: [PATCH11/11] ptrace: implement group stop notification for ptracer]

From: Jan Kratochvil
Date: Mon May 16 2011 - 08:17:33 EST


Hi Tejun,

On Mon, 16 May 2011 10:43:50 +0200, Tejun Heo wrote:
> There's distinction between "broken" and "ugly". If it's ugly but
> functional, you don't need to "fix" it.

The final goal is the user experience (such as the users of GDB), nothing else
matters. If it is so "ugly" the userland developers fail to use it the
project as a whole still broken.


> Frankly, I think the biggest disease was this obsession with
> perfection.

I try to suggest fixes which seem to be easier on the kernel side than trying
to workaround them in all the debugger-like applications. After various
strace fixes and for years gdb linux-nat fixes there is a need to move to
gdbserver which will mean to reimplement all the ptrace workarounds again.


> So, I'm gonna push back quite a bit unless it actually compromises
> functionality or correctness.

With your position "if it is workaroundable in userland let's make the new
kernel API broken again" it no longer makes sense to comment on it. Yes,
everything is workaroundable but that is usually not the goal of new APIs.


Thanks,
Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/