Re: [PATCH net-next-2.6 v2] net: ping: dont call udp_ioctl()
From: Vasiliy Kulikov
Date: Mon May 16 2011 - 08:48:40 EST
On Mon, May 16, 2011 at 09:26 +0200, Eric Dumazet wrote:
> Le dimanche 15 mai 2011 à 17:44 -0400, David Miller a écrit :
> > Just get rid of ping_ioctl() entirely, as that is the effect of
> > this change since inet_ioctl() returns -ENOIOCTLCMD when
> > sk_prot->ioctl is NULL.
> > Also get rid of asm/ioctls.h since that will be no longer needed.
> Sure, here is updated version, thanks.
> [PATCH net-next-2.6 v2] net: ping: dont call udp_ioctl()
> udp_ioctl() really handles UDP and UDPLite protocols.
> 1) It can increment UDP_MIB_INERRORS in case first_packet_length() finds
> a frame with bad checksum.
> 2) It has a dependency on sizeof(struct udphdr), not applicable to
> If ping sockets need to handle SIOCINQ/SIOCOUTQ ioctl, this should be
> done differently.
> Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Acked-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
http://www.openwall.com - bringing security into open computing environments
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/