Re: [PATCH 01/10] signal: remove three noop tracehooks

[Tejun Heo]

Hello,

On Tue, May 17, 2011 at 12:22:24PM -0400, Christoph Hellwig wrote:
> On Mon, May 16, 2011 at 08:17:20PM +0200, Tejun Heo wrote:
> > Remove the following three noop tracehooks in signals.c.
> > 
> > * tracehook_force_sigpending()
> > * tracehook_get_signal()
> > * tracehook_finish_jctl()
> > 
> > The code area is about to be updated and these hooks don't do anything
> > other than obfuscating the logic.
> 
> Btw, I think we should kill that stupid <linux/tracehook.h> layer
> entirely.  It consists of a few relatively useful function which should
> just be renamed to ptrace_* and moved to ptrace.c, and a lot of entirely
> pointless wrappers which generally have only a single user, and often
> tons of arguments that aren't actually used.

Yeap, agreed.  It's on the todo list.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/