Re: [PATCH 1/3] comm: Introduce comm_lock seqlock to protect task->commaccess
From: KOSAKI Motohiro
Date: Tue May 17 2011 - 20:28:52 EST
(2011/05/17 6:19), John Stultz wrote:
> The implicit rules for current->comm access being safe without locking
> are no longer true. Accessing current->comm without holding the task
> lock may result in null or incomplete strings (however, access won't
> run off the end of the string).
> In order to properly fix this, I've introduced a comm_lock spinlock
> which will protect comm access and modified get_task_comm() and
> set_task_comm() to use it.
> Since there are a number of cases where comm access is open-coded
> safely grabbing the task_lock(), we preserve the task locking in
> set_task_comm, so those users are also safe.
> With this patch, users that access current->comm without a lock
> are still prone to null/incomplete comm strings, but it should
> be no worse then it is now.
> The next step is to go through and convert all comm accesses to
> use get_task_comm(). This is substantial, but can be done bit by
> bit, reducing the race windows with each patch.
> CC: Ted Ts'o<tytso@xxxxxxx>
> CC: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
> CC: David Rientjes<rientjes@xxxxxxxxxx>
> CC: Dave Hansen<dave@xxxxxxxxxxxxxxxxxx>
> CC: Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx>
> CC: linux-mm@xxxxxxxxx
> Acked-by: David Rientjes<rientjes@xxxxxxxxxx>
> Signed-off-by: John Stultz<john.stultz@xxxxxxxxxx>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/