Re: [PATCH 9/9] x86/lib/memset_64.S: Optimize memset by enhanced REPMOVSB/STOSB
From: Andi Kleen
Date: Tue May 17 2011 - 22:57:51 EST
> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Support memset() with enhanced rep stosb. On processors supporting
> REP MOVSB/STOSB, the alternative memset_c_e function using enhanced rep
> overrides the fast string alternative memset_c and the original function.
FWIW most memsets and memcpys are generated by modern gccs as inline code,
depending on alignment etc., so will never call your new function.
Same may be true for memmove (not fully sure)
One way to work around this would be to add suitable logic
to the string.h macros and make sure the out of line code is always
called for large copies if the count is constant and large enough.
There used to be such logic, but it was removed partly later.
The only problem is that it's hard to decide if the count is variable
and where a good threshold is.
Or maybe it would be better to just fix gcc to use the new instructions,
but then it would be difficult to patch them in.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/