Re: [PATCH v2 1/3] coredump: use get_task_comm for %e filenameformat
From: Oleg Nesterov
Date: Wed May 18 2011 - 09:02:24 EST
Sorry for delay,
On 05/12, Jiri Slaby wrote:
> We currently access current->comm directly. As we have
> prctl(PR_SET_NAME), we need the access be protected by task_lock. This
> is exactly what get_task_comm does, so use it.
> I'm not 100% convinced prctl(PR_SET_NAME) may be called at the time of
> core dump,
It can't be called. Apart from current, a sub-thread can change ->comm
via /proc/pid/comm, but we already killed all threads.
> but the locking won't hurt.
Agreed, the patch looks correct. but still unneeded.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/