Re: [PATCH 1/2] of: fix race when matching drivers

From: David Miller
Date: Wed May 18 2011 - 17:04:25 EST

From: Grant Likely <grant.likely@xxxxxxxxxxxx>
Date: Wed, 18 May 2011 13:21:00 -0600

> From: Milton Miller <miltonm@xxxxxxx>
> If two drivers are probing devices at the same time, both will write
> their match table result to the dev->of_match cache at the same time.
> Only write the result if the device matches.
> In a thread titled "SBus devices sometimes detected, sometimes not",
> Meelis reported his SBus hme was not detected about 50% of the time.
>>From the debug suggested by Grant it was obvious another driver matched
> some devices between the call to match the hme and the hme discovery
> failling.
> Reported-by: Meelis Roos <mroos@xxxxxxxx>
> Signed-off-by: Milton Miller <miltonm@xxxxxxx>
> [grant.likely: modified to only call of_match_device() once]
> Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxxxx>

Tested on SunBlade2500 and Niagara2+

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at