Re: [PATCH v2] dma-debug: print some unfreed allocations

[Johannes Berg]

On Mon, 2011-05-16 at 13:00 +0200, Roedel, Joerg wrote:
> > +		/*
> > +		 * If we have, print out some stack traces for the allocations.
> > +		 * In case of module unload, the stack traces will be useless,
> > +		 * but instead of unloading the module you can manually unbind
> > +		 * the driver instead and get useful traces.
> > +		 */
> > +		printk(KERN_WARNING "Showing traces for %d allocations:\n",
> > +		       DMA_DEBUG_NUM_PRINT_UNFREED);

> This is surely useful to developers, but can trash the dmesg if done
> unconditionally. I would prefer this verbose output to be configurable
> and off by default.

Are you thinking of runtime or compile time configuration? Kconfig entry
depending on stacktrace (or selecting it, depending on have_stacktrace)
would be easy enough.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/