Re: patch for Checkpatch.pl

From: Greg KH
Date: Thu May 19 2011 - 00:33:25 EST


On Thu, May 19, 2011 at 09:33:08AM +0530, anish singh wrote:
>
>
> On Thu, May 19, 2011 at 9:28 AM, Greg KH <greg@xxxxxxxxx> wrote:
>
> On Thu, May 19, 2011 at 08:39:57AM +0530, anish singh wrote:
> > I am thinking of submitting a patch for checkpatch.pl.
> >  
> > Ideally it should give a warning when there is no space between
> > patch submitter name and the email id as below:
> > Signed-off-by: anish kumar<anish@xxxxxxxxx>
> >  
> > It should be as below:
> > Signed-off-by: anish kumar <anish@xxxxxxxxx>
> >  
> > Please let me know if it is fine.I will send it right away as i have
> > it ready.
>
> As you are the only one I have ever seen do this before, I doubt it's
> really needed for the checkpatch script, right?
>
> Yes my bad but when we don't add space after Signed-off-by:_
> it says that space is required.So thought this is also required.
> Anyway if it is not needed i am ok.

If it's a simple patch, that's fine, send it in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/