Re: New boot time message: detected capacity change

From: Tejun Heo
Date: Thu May 19 2011 - 01:29:15 EST


Hello, Linus.

On Wed, May 18, 2011 at 01:50:19PM -0700, Linus Torvalds wrote:
> As it was, I feel that those commit descriptions were actively
> misleading me into thinking this was a regression.

The commit message is incomplete rather than misleading. The problem
has been there for a long time but hasn't affected cdrom so not many
people have noticed it. The changes to media revalidation exposed the
bug for cdrom too, so it became a regression for 2.6.38. Please refer
to the following thread.

https://lkml.org/lkml/2011/3/31/436

As the root cause was the same as the 2009 bug, I just referenced that
one. I should have included the link to the newer thread or explained
how it affected recent conversion from ->media_changed to
->check_events. My bad.

> Maybe it won't cause any problems, but -rc7 is not the time to make
> these kinds of experiments!

The patch was posted Apr 6th. It somehow took quite long to reach
your tree. Sorry about that too.

As for the warning message, I think it wouldn't be harmful but at -rc7
I'm a bit nervous too. I'll take a deeper look.

Thank you.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/