Re: [patch 4/7] clockevents: Provide combined configure and registerfunction

From: Ingo Molnar
Date: Thu May 19 2011 - 05:09:10 EST

* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> +extern void clockevents_config_and_register(struct clock_event_device *dev,
> + u32 freq, unsigned long min_delta,
> + unsigned long max_delta);

might be worth collecting these fields into a clocksource_params structure:

struct clocksource_params {
u32 freq;
unsigned long min_delta;
unsigned long max_delta;

That way the initialization API looks even more streamlined:

extern void
clockevents_config_and_register(struct clock_event_device *dev,
struct clocksource_params params);

and could be extended in the future, without having to update every single
clocksource driver again.

But a good first step in any case:

Reviewed-by: Ingo Molnar <mingo@xxxxxxx>


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at