Re: [PATCH 4/7] [RFC] enable L1_WRITETHROUGH mode for BG/P

From: Eric Van Hensbergen
Date: Thu May 19 2011 - 08:53:40 EST

On Thu, May 19, 2011 at 5:43 AM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxxx> wrote:
> On Wed, May 18, 2011 at 04:24:52PM -0500, Eric Van Hensbergen wrote:
>>+      bool "Blue Gene/P enabled writethrough mode"
>>+      depends on BGP
>>+      default y
> You add this config option here, named generically, but then make it
> depend on BGP.  It sees it should be named BGP_L1_WRITETHROUGH, and then
> just selected by the BGP platform.  But then....
>> endmenu
>>diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
>>index 111138c..3a3c711 100644
>>--- a/arch/powerpc/platforms/Kconfig.cputype
>>+++ b/arch/powerpc/platforms/Kconfig.cputype
>>@@ -329,9 +329,13 @@ config NOT_COHERENT_CACHE
>>       bool
>>       depends on 4xx || 8xx || E200 || PPC_MPC512x || GAMECUBE_COMMON
>>       default n if PPC_47x
>>+      default n if BGP
>>       default y
>>       bool
>>+      bool
> You add an identical option down here.  Confused.

Yeah, this was copied from the original patches and it confused me as
well, but I had never
modified Kconfig.cputype before so I wasn't sure if there were some
weird rules. I'm happy
to remove the vestigial one and make the changes you suggest to make
the naming BGP

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at