Re: [PATCH 07/10] ptrace: make group stop state visible viaPTRACE_GETSIGINFO

[Tejun Heo]

On Thu, May 19, 2011 at 06:27:41PM +0200, Oleg Nesterov wrote:
> On 05/16, Tejun Heo wrote:
> > @@ -585,6 +587,23 @@ static int ptrace_getsiginfo(struct task_struct *child, siginfo_t *info)
> >
> >  	error = 0;
> >  	*info = *child->last_siginfo;
> > +
> > +	/*
> > +	 * If reporting ptrace trap for a seized tracee, enable reporting
> > +	 * of info->si_pt_flags.
> > +	 */
> > +	if ((child->ptrace & PT_SEIZED) &&
> > +	    (info->si_code & __SI_MASK) == __SI_TRAP) {
> > +		/*
> > +		 * Report whether group stop is in effect w/ SI_STOPPED and
> > +		 * if so which signal caused it.
> > +		 */
> > +		if (sig->group_stop_count || sig->flags & SIGNAL_STOP_STOPPED) {
> 
> Cosmetic nit, you could declare "struct signal_struct *sig" here, under
> if (PT_SEIZED && __SI_TRAP).

Yeap, sure.  Will update.

> I must admit, personally I still dislike this new PTRACE_GETSIGINFO API...
> But I can't suggest anything better, so I am not going to argue.

It's not the prettiest, I agree, but it is more or less in line with
the rest of the interface, so...

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/