Re: [PATCH] mfd wm8350: allocate irq descs dynamically

From: Mark Brown
Date: Thu May 19 2011 - 18:04:12 EST

On Thu, May 19, 2011 at 08:56:48PM +0200, Sascha Hauer wrote:

> + if (!pdata->irq_base) {
> + wm8350->irq_base = irq_alloc_descs(-1, 0, ARRAY_SIZE(wm8350_irqs), 0);
> + if (wm8350->irq_base < 0) {

One other thing - it doesn't seem to be 100% desirable to making the
allocation of the IRQ descriptors depend on not specifying a base - for
many situations we're likely to want to know what the numbers we end up
with are (eg, for passing to another device) but if we don't call
irq_alloc_decs() the platform still has to arrange for the descriptors
to be there in advance. It feels like the code should always use
irq_alloc_descs(), though obviously that's not going to work right now.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at