Re: [PATCHSET ptrace] ptrace: implement PTRACE_SEIZE/INTERRUPT and group stop notification, take#2
From: Denys Vlasenko
Date: Thu May 19 2011 - 18:45:53 EST
On Thursday 19 May 2011 17:04, Linus Torvalds wrote:
> On Mon, May 16, 2011 at 11:17 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > This is the second try at implementing PTRACE_SEIZE/INTERRUPT and
> > group stop notification. Notable changes from the first take are,
> > * Prep patches moved to a separate patchset.
> So having followed the discussion so far, quite frankly I'm not
> convinced this series is 2.6.40 material.
> I think that conceptually the split-up of PTRACE_ATTACH into
> SEIZE/INTERRUPT might be fine, but I don't think the interface is
> necessarily cooked, and perhaps more importantly I'm not at all sure
> that the (few) current users of ptrace() would even switch over.
I will push strace to at least use what we already have (TRACESYSGOOD etc).
> So I think Oleg's branch with cleanups is probably ready, and maybe a
> few of the preparatory patches from this branch can be merged, but I
> would _strongly_ suggest that the plan for 2.6.40 should be to not
> actually mess with interfaces to the kernel, but just cleaning up the
> actual internal implementation. I would like to keep 2.6.40 small and
strace wasn't handling ^Z correctly for many years. It definitely can wait
for another kernel release cycle.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/