Re: [PATCH 6/6] hid-multitouch: class MT_CLS_STANTUM is redundantwith MT_CLS_CONFIDENCE

From: Jiri Kosina
Date: Fri May 20 2011 - 04:35:16 EST


On Thu, 19 May 2011, Benjamin Tissoires wrote:

> Stantum devices used to work with MT_CLS_STANTUM but MT_CLS_CONFIDENCE
> is exactly the same. This patch switches them to this generic class,
> and remove the unused MT_CLS_STANTUM.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxx>
> ---
> drivers/hid/hid-multitouch.c | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index feeb0b7..65b92d2 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -88,7 +88,6 @@ struct mt_class {
> #define MT_CLS_DUAL_INRANGE_CONTACTNUMBER 3
> #define MT_CLS_CYPRESS 4
> #define MT_CLS_EGALAX 5
> -#define MT_CLS_STANTUM 6
> #define MT_CLS_3M 7
> #define MT_CLS_CONFIDENCE 8
> #define MT_CLS_CONFIDENCE_MINUS_ONE 9

Benjamin,

is it intentional that you are leaving the hole in the numbering here?

I don't think there would be any issue with re-numbering 7-10, would it?

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/