Re: [PATCH 0/4] add gpio driver gpio-mxs

[Shawn Guo]

On Fri, May 20, 2011 at 12:02:42PM +0200, Sascha Hauer wrote:
> Hi Shawn,
> 
Hi Sascha,

> On Fri, May 20, 2011 at 05:51:25PM +0800, Shawn Guo wrote:
> > The patch set is to move Freescale MXS gpio driver from mach-mxs
> > into drivers/gpio.  Different from u300 gpio driver that all gpio
> > ports are registered as one device, gpio-mxs expects every single
> > port is a gpio device.
> > 
> > The first 3 patches are just to ease review and can be squashed into
> > the last one.
> > 
> > Shawn Guo (4):
> >       gpio: gpio-mxs: add file gpio-mxs.c
> >       gpio: gpio-mxs: drop mach-specific accessors
> >       gpio: gpio-mxs: remove gpio port definition and registration
> >       gpio: gpio-mxs: add gpio driver for Freescale MXS architecture
> 
> Your series should be bisectible. So please either:
> 
> - Add the driver the way you want it (no need to modify a new file in
>   four steps)

As I said above, I split it into 4 patches just to ease the review,
and they can be squashed into one when applying.

> - atomically switch to the new driver
> - remove old driver
> 
These two steps happened in the patch set '[PATCH 0/3] remove mach-mxs
gpio driver'.  The patch order should be reworked though.

BTW, are you looking at moving plat-mxc/gpio.c, or I can give a hand
there?

-- 
Regards,
Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/