Re: [PATCH 5/9] HWPoison: add memory_failure_queue()

From: Ingo Molnar
Date: Fri May 20 2011 - 07:56:38 EST

* Huang Ying <ying.huang@xxxxxxxxx> wrote:

> > So why are we not working towards integrating this into our event
> > reporting/handling framework, as i suggested it from day one on when you
> > started posting these patches?
> The memory_failure_queue() introduced in this patch is general, that is, it
> can be used not only by ACPI/APEI, but also any other hardware error
> handlers, including your event reporting/handling framework.

Well, the bit you are steadfastly ignoring is what i have made clear well
before you started adding these facilities: THEY ALREADY EXISTS to a large
degree :-)

So you were and are duplicating code instead of using and extending existing
event processing facilities. It does not matter one little bit that the code
you added is partly 'generic', it's still overlapping and duplicated.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at