Re: [RFC] lib: crc8: add new library module providing crc8algorithm

[Arend van Spriel]

On 05/22/2011 10:59 AM, Nicolas Kaiser wrote:
> * "Arend van Spriel"<arend@xxxxxxxxxxxx>:
> > +/**
> > + * crc8() - calculate a crc8 over the given input data
> > + *
> > + * @pdata:	pointer to data buffer.
> > + * @nbytes:	number of bytes in data buffer.
> > + * @crc:	previous returned crc8 value.
> > + *
> > + * The CRC8 is calculated using the polynomial given below.
> > + *
> > + * x^8 + x^7 +x^6 + x^4 + x^2 + 1
>                   ^
> Could you possibly add a space here ...
>
> > +/*
> > + * table for crc8 calculation based on following polynomial:
> > + *	x^8 + x^7 +x^6 + x^4 + x^2 + 1
>                     ^
>             ... and here?
>
> Best regards,
> Nicolas Kaiser

Done. Will wait for some more feedback before posting a new version.

Gr. AvS

--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/