Re: Adding an ugliness in __read_cache_page()?
From: Linus Torvalds
Date: Sun May 22 2011 - 19:47:04 EST
On Sun, May 22, 2011 at 3:25 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> But drivers/gpu/drm i915 and ttm are using read_cache_page_gfp() or
> read_mapping_page() on tmpfs: on objects created by shmem_file_setup().
> Nothing else uses read_cache_page_gfp(). I cannot find anything else
> using read_mapping_page() on tmpfs, but wonder if something might be
> out there. Stacked filesystems appear not to go that way nowadays.
> Would it be better to make i915 and ttm call shmem_read_cache_page()
> directly? Perhaps removing the then unused read_cache_page_gfp(), or
> perhaps not: may still be needed for i915 and ttm on tiny !SHMEM ramfs.
I would certainly prefer the "make i915 and ttm call
shmem_read_cache_page directly" approach over putting some nasty hack
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/