Re: Adding an ugliness in __read_cache_page()?

From: Hugh Dickins
Date: Sun May 22 2011 - 20:03:24 EST

On Sun, 22 May 2011, Linus Torvalds wrote:
> On Sun, May 22, 2011 at 3:25 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> >
> > Would it be better to make i915 and ttm call shmem_read_cache_page()
> > directly?  Perhaps removing the then unused read_cache_page_gfp(), or
> > perhaps not: may still be needed for i915 and ttm on tiny !SHMEM ramfs.
> I would certainly prefer the "make i915 and ttm call
> shmem_read_cache_page directly" approach over putting some nasty hack
> in __read_cache_page.

Thank you: I'll go that way.