Re: [v3 00/39] faster tree-based sysctl implementation

From: Eric W. Biederman
Date: Mon May 23 2011 - 00:27:29 EST

Lucian Adrian Grijincu <lucian.grijincu@xxxxxxxxx> writes:

> Hi
> This is version 3 of a patch series that introduces a faster/leaner
> sysctl internal implementation.
> Due to high number of patches and low general interest I'll just point
> you to the tree/branch:
> git:// v3-new-sysctl-alg
> Patches are on top of v2.6.39. I did not pick a more recent (random)
> point in Linus' tree to rebase these onto to not mess up testing.

Thanks for keeping going on this.

This patchset looks like it is deserving of some close scrutiny, and
not just the high level design overview I have given the previous
patches. This is going to be a busy week for me so I probably won't
get through all of the patches for a while.

I will mention a couple of nits I noticed while I was skimming through
your patches.
- There can be multiple proc superblocks and thus multiple inodes
referring to the same /proc/sys file, if there are multiple pid

- I have a hope to move /proc/sys into /proc/<pid>/sys so we don't have
to look at current to determine the namespace we want to display.
That would allow the deeply magic sysctl_is_seen check to be removed
from proc_sys_compare. That is not your problem, but of an
explanation why the namespaces are passed through.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at