Re: [PATCH 4/5] oom: don't kill random process

From: KOSAKI Motohiro
Date: Mon May 23 2011 - 21:54:11 EST

+ /*
+ * chosen_point==1 may be a sign that root privilege bonus is too large
+ * and we choose wrong task. Let's recalculate oom score without the
+ * dubious bonus.
+ */
+ if (protect_root&& (chosen_points == 1)) {
+ protect_root = 0;
+ goto retry;
+ }

The idea is good to me.
But once we meet it, should we give up protecting root privileged processes?
How about decaying bonus point?

After applying my patch, unprivileged process never get score-1. (note, mapping
anon pages naturally makes to increase nr_ptes)

Then, decaying don't make any accuracy. Am I missing something?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at