Re: [PATCH 1/3] x86, intel: Output microcode revision

From: Fenghua Yu
Date: Tue May 24 2011 - 20:39:57 EST


>@@ -300,6 +295,7 @@ static int apply_microcode(int cpu)
> struct ucode_cpu_info *uci;
> unsigned int val[2];
> int cpu_num;
>+ struct cpuinfo_x86 *c = &cpu_data(cpu_num);

This is wrong. cpu_num is not initialized yet at this point. You need to assign c after cpu_num is initialized in the next statement.

>
> cpu_num = raw_smp_processor_id();
> uci = ucode_cpu_info + cpu;

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/