Re: [PATCH 2/4] cfq-iosched: reduce bit operations incfq_choose_req()

From: Namhyung Kim
Date: Tue May 24 2011 - 22:34:56 EST


2011-05-24 (í), 10:34 -0700, Justin TerAvest:
> Why make this change? Are we that sensitive to the number of operations?
>
> It makes the code a bit harder to read, I think.
>

Hi Justin,

I thought that the function is a sort of hot path operation so it would
be better make it even a bit faster, no? And if you guys think this
patch makes the code harder we can add a comment, although I don't think
it's hard enough. :)

Thanks.


--
Regards,
Namhyung Kim


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/