Re: [PATCH] Fix corruption of CONFIG_X86_32 in 'make oldconfig'

From: David Woodhouse
Date: Mon May 30 2011 - 07:07:10 EST


On Mon, 2011-05-30 at 12:58 +0200, Ingo Molnar wrote:
>
> * Theodore Tso <tytso@xxxxxxx> wrote:
>
> > I'd think that "make ARCH=x86_64 oldconfig"
> >
> > ... where the old configuration contained CONFIG_X86_32
> > should trigger a warning, if not an outright error that
> > stops the build....
>
> That would be a rather sad regression for me: i use that command
> regularly to transform .configs that came in bugreports into a config
> suitable for a testbox that has a different bitness userspace
> installed.

And if it has a different SCSI or ATA controller? Then you need
something like:

'make CONFIG_SATA_MV=y oldconfig'

to make your config actually useful.

Which only goes to reinforce my point that CONFIG_64BIT *isn't* that
special.

Yes, we should fix the tools so that it's easy to *fix* certain settings
when running randconfig/oldconfig/all*config. That addresses *all* your
examples that you posted in a separate mail, doesn't it?

Without being a dirty hack which only works for *one* setting
(CONFIG_64BIT), and only works on *one* architecture (there is no
equivalent ARCH= hack for setting CONFIG_64BIT on
powerpc/mips/sparc/sh/parisc).

--
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/