Re: m68k: Convert to genirq (WIP)

[Geert Uytterhoeven]

On Sat, May 28, 2011 at 20:32, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> | NR_IRQS:72
> | ------------[ cut here ]------------
> | WARNING: at linux/kernel/irq/chip.c:559 0x2a191a()
> | Modules linked in:
> | Call Trace: [<0002767e>] warn_slowpath_common+0x4c/0x64
> | Â[<0004e81c>] irq_set_chip+0x0/0x66
> | Â[<000276aa>] warn_slowpath_null+0x14/0x1a
> | Â[<0004e728>] __irq_set_handler+0x11c/0x13c
> | Â[<0004ec7e>] handle_level_irq+0x0/0x9c
> | Â[<00003ef4>] m68k_setup_irq_controller+0x3c/0x50
> | Â[<0004ec7e>] handle_level_irq+0x0/0x9c
> | Â[<0004e81c>] irq_set_chip+0x0/0x66
> | Â[<00027dc8>] printk+0x0/0x1a
> | Â[<00322022>] __alloc_bootmem+0x0/0x1a
> | Â[<0031dea4>] atari_init_IRQ+0x2a/0xe8
> | Â[<0004ec7e>] handle_level_irq+0x0/0x9c
> | Â[<0031c450>] init_IRQ+0x28/0x2e
> | Â[<00027dc8>] printk+0x0/0x1a
> | Â[<0031a012>] start_kernel+0x196/0x3b0
> | Â[<0031931e>] _sinittext+0x31e/0x9c0
> |
> | ---[ end trace 139ce121c98e96c9 ]---

whitespace-challenged diff --git a/arch/m68k/kernel/ints.c
b/arch/m68k/kernel/ints.c
index f4804f3..8d8a1e9 100644
--- a/arch/m68k/kernel/ints.c
+++ b/arch/m68k/kernel/ints.c
@@ -285,7 +285,7 @@ void m68k_setup_irq_controller(struct irq_chip *chip,
        for (i = 0; i < cnt; i++) {
                irq_set_chip(irq + i, chip);
                if (handle)
-                       irq_set_handler(i, handle);
+                       irq_set_handler(irq + i, handle);
        }
 }

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/