Re: [PATCH 7/14] drm/i915: adjust to new truncate_range

From: Hugh Dickins
Date: Wed Jun 01 2011 - 13:04:15 EST


On Tue, 31 May 2011, Christoph Hellwig wrote:

> > /* Our goal here is to return as much of the memory as
> > * is possible back to the system as we are called from OOM.
> > * To do this we must instruct the shmfs to drop all of its
> > - * backing pages, *now*. Here we mirror the actions taken
> > - * when by shmem_delete_inode() to release the backing store.
> > + * backing pages, *now*.
> > */
> > inode = obj->base.filp->f_path.dentry->d_inode;
> > - truncate_inode_pages(inode->i_mapping, 0);
> > if (inode->i_op->truncate_range)
> > inode->i_op->truncate_range(inode, 0, (loff_t)-1);
> > + else
> > + truncate_inode_pages(inode->i_mapping, 0);
>
> Given that it relies on beeing on shmemfs it should just call it
> directly.

As agreed in other mail, I'll do a v2 series in a few days,
making that change - thanks.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/