Re: [PATCH 4/8] mfd: twl6040: Add initial support

From: Peter Ujfalusi
Date: Fri Jun 03 2011 - 14:39:44 EST


On Wednesday 01 June 2011 16:47:21 Krishnamoorthy, Balaji T wrote:
> > +int twl6040_reg_read(struct twl6040 *twl6040, unsigned int reg)
> > +{
> > + int ret;
> > + u8 val = 0;
> > +
> > + mutex_lock(&twl6040->io_mutex);
> > + ret = twl_i2c_read_u8(TWL_MODULE_AUDIO_VOICE, &val, reg);
>
> Can this dependency on twl_i2c_[read/write] be removed,
> Since TWL6040 is a separate IC which can get its own i2c_client in
> twl6040-core.c and
> create its own mfd devices like vibra, audio-codec ... while creating
> twl6040-core.c

You are right, twl6040 is separate IC.
I'll take a look how it can be separated from the twl-core (twl6030).

Thanks for noticing this,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/