Re: [PATCH] spi: reorganize drivers
From: Geert Uytterhoeven
Date: Sun Jun 05 2011 - 07:50:08 EST
On Sun, Jun 5, 2011 at 09:54, Baruch Siach <baruch@xxxxxxxxxx> wrote:
> On Sun, Jun 05, 2011 at 01:13:28PM +0530, Jassi Brar wrote:
>> On Sun, Jun 5, 2011 at 12:48 PM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
>> > [repost: I had a typo on the spi-devel-general mailing list address]
>> > Sort the SPI makefile and enforce the naming convention spi_*.c for
>> > spi drivers.
>> Though the spi_ prefix seems redundant considering the files are in
>> 'spi' directory.
>> Just a thought, no objection.
> When looking at the list of loaded modules (e.g. in an Oops message), the name
> "spi_xilinx" is much more meaningful than just "xilinx", for example.
Plus, when dropping the prefix, spi_xilinx.ko and gpio-xilinx.ko
become the same...
So now we have spi_<name>.c (with underscore) and gpio-<name>.c (with dash)?
And other subsystems go with <name>-<type>.c instead, e.g.
Â Â Â Â Â Â Â Â Â Â Â Â Geert
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
Â Â Â Â Â Â Â Â Â Â Â Â Â ÂÂ ÂÂ -- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/