Re: [PATCH] spi: reorganize drivers

From: Grant Likely
Date: Sun Jun 05 2011 - 16:58:15 EST

On Sun, Jun 5, 2011 at 7:12 AM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
> Hi Baruch,
> On Sun, Jun 5, 2011 at 1:24 PM, Baruch Siach <baruch@xxxxxxxxxx> wrote:
>>> Though the spi_ prefix seems redundant considering the files are in
>>> 'spi' directory.
>>> Just a thought, no objection.
>> When looking at the list of loaded modules (e.g. in an Oops message), the name
>> "spi_xilinx" is much more meaningful than just "xilinx", for example.
> Good catch.
> Perhaps we could get Makefile to build modules with spi_ prefix. Just
> like USB gadgets do ?

I don't think it's worth mucking about with <module_name>-y :=
filename.o when the filename can just be made the same as the module


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at