Re: [PATCH] spi: reorganize drivers
From: Jassi Brar
Date: Sun Jun 05 2011 - 17:19:42 EST
> On Sun, Jun 5, 2011 at 5:49 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>>>> Though the spi_ prefix seems redundant considering the files are in
>>>> 'spi' directory.
>>>> Just a thought, no objection.
>>> When looking at the list of loaded modules (e.g. in an Oops message), the name
>>> "spi_xilinx" is much more meaningful than just "xilinx", for example.
>> Plus, when dropping the prefix, spi_xilinx.ko and gpio-xilinx.ko
>> become the same...
As I said, the modules could still be made spi_xilinx.ko from
and gpio_xilinx.ko from drivers/gpio/xilinx.c
On Mon, Jun 6, 2011 at 2:25 AM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
>> Perhaps we could get Makefile to build modules with spi_ prefix. Just
>> like USB gadgets do ?
> I don't think it's worth mucking about with <module_name>-y :=
> filename.o when the filename can just be made the same as the module
Well, the solution was for discarding the 'redundant' prefix and yet
have device specific
module names. Not just for the sake of it.
Anyways, I don't wanna be bitchy about it. I can buy at face value
from a maintainer.
I am ok with the proposed naming.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/