Re: [PATCH 3/8] MFD: twl4030-audio: Rename platform data
From: Tony Lindgren
Date: Mon Jun 06 2011 - 05:55:50 EST
* Peter Ujfalusi <peter.ujfalusi@xxxxxx> [110603 16:34]:
> On Friday 03 June 2011 11:08:22 Tony Lindgren wrote:
> > Yeah if it gets big then a separate file is better. Also, if we have
> > a common init function for twl, then it's easy to add the board specific
> > device tree initialization to that too and just leave out the calls to
> > omap_pmic_init from board-*.c files.
> I have parsed the board files for a pattern.
> There are some, but I have my doubts as well:
> We have eight platform data members in twl4030_platform_data for child
> USB, and audio/codec configuration might worth to move out (since most of the
> board does not have fine tuned parameters for codec).
> The majority of the code related to pmic is coming from regulator setups, I
> can see similarities, but there are differences here and there, which makes
> the common configuration mostly useless (different peripherals, boot loader
> diffs, etc).
Yeah we still need the board specific data passed for sure.
> Having said that, I try to create a wrapper for omap_pmic_init, which can
> replace the current omap2/3/4_pmic_init, with that we can use common config
> for USB, audio, and some selected few regulators initially.
> Later other parts might be possible to consolidate as well.
> I'm going to call this new wrapper for now omap2/3/4_pmic_config.
> Is this a good way to approach this issue?
Sounds good to me!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/