Re: [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV_KERNEL

From: AmÃrico Wang
Date: Mon Jun 06 2011 - 11:52:36 EST


On Sun, Jun 5, 2011 at 4:21 PM, Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
> CONFIG_CONSTRUCTORS controls support for running constructor functions
> at kernel init time. ÂAccording to commit
> b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7, gcov (CONFIG_GCOV_KERNEL)
> needs this. ÂHowever, CONFIG_CONSTRUCTORS currently defaults to y, with
> no option to disable it, and CONFIG_GCOV_KERNEL depends on it. ÂInstead,
> default it to n and have CONFIG_GCOV_KERNEL select it, so that the
> normal case of CONFIG_GCOV_KERNEL=n will result in
> CONFIG_CONSTRUCTORS=n.
>
> Observed in the short list of =y values in a minimal kernel
> configuration.
>
> Signed-off-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Yeah, this is reasonable, so,

Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/