Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.
From: Joe Perches
Date: Mon Jun 06 2011 - 18:11:04 EST
On Mon, 2011-06-06 at 14:55 -0700, Greg KH wrote:
> On Tue, Jun 07, 2011 at 12:37:37AM +0530, anish wrote:
> > From: anish kumar <anish198519851985@xxxxxxxxx>
> > Replace kmalloc with local variables as it was un-necessary and
> > also removed the redudant code after this change.
> SPI data, like USB data, has to come from kmalloced data, not from the
> stack, or bad things can, and will, happen.
Perhaps just add a comment like:
+ u8 *tx = kmalloc(2, GFP_KERNEL); /* can't be on stack */
It might be better to do a single kmalloc(4)
than 2 separate kmalloc(2)'s.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/