RE: [PATCH v2] spi: reorganize drivers
From: Du, Alek
Date: Tue Jun 07 2011 - 00:52:47 EST
After the latest patches that Feng Tang sent out for SPI were merged, I don't see any good reason to do big change. It just works perfectly.
From: Tang, Feng
Sent: Tuesday, June 07, 2011 12:49 PM
To: Grant Likely
Cc: Dirk Brandewie; spi-devel-general@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Mike Frysinger; Du, Alek; alan@xxxxxxxxxxxxxxx; jean-hugues.deschenes@xxxxxxxxxxx
Subject: Re: [PATCH v2] spi: reorganize drivers
On Tue, 7 Jun 2011 12:09:52 +0800
Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> On Mon, Jun 6, 2011 at 8:28 PM, Feng Tang <feng.tang@xxxxxxxxx> wrote:
> > On Tue, 7 Jun 2011 00:49:20 +0800
> > Dirk Brandewie <dirk.brandewie@xxxxxxxxx> wrote:
> >> On 06/06/2011 09:38 AM, Grant Likely wrote:
> >> > On Mon, Jun 6, 2011 at 10:31 AM, Mike
> >> > Frysinger<vapier.adi@xxxxxxxxx> wrote:
> >> >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote:
> >> >>> Sort the SPI makefile and enforce the naming convention spi_*.c
> >> >>> for spi drivers.
> >> >>
> >> >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but
> >> >> perhaps those are only for /proc/ status tracking ? worth
> >> >> double checking ...
> >> >
> >> > I just talked with Dirk Brandewie, who has a major rewrite to the
> >> > topcliff spi driver. I'll let him comment on whether or not
> >> > changing KBUILD_MODNAME will cause any problems.
> >> >
> >> My changes are to the designware driver :-) I will get my patches
> >> re-based onto the spi-next branch and see if there any issues.
> > If there is major rewrite to the dw_spi driver, please submit to
> > this list, as it is used by many devices out there and needs a
> > broad review
> Hmmm. Dirk, that could change things a bit. From our conversation
> today my understanding was that there weren't few if any users outside
> of your circle. If that isn't the case, then I'm going to be more
> cautious about merging the rewrite. Who are the people I should make
> sure there is feedback from when the patch gets posted?
I don't know all the devices and users, but here is what I know: I've tested
Max3110 spi-uart (in-tree), Option GTM501L high-speed 3G modem (out of tree),
ektf1236 spi touch screen (out of tree). Alek Du (Cced) should have tested
current dw_spi driver with some spi bluetooth device and modem device. Also
the original author fordw_spi_mmio.c Jean-Hugues Deschense should have some
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/