Re: [PATCH] sched: RCU-protect __set_task_cpu() in set_task_cpu()

From: Oleg Nesterov
Date: Tue Jun 07 2011 - 10:05:56 EST


On 06/07, Peter Zijlstra wrote:
>
> Cure this by passing the migration state in wake_flags. Also move the
> whole test under CONFIG_SMP, its hard to migrate tasks on UP :-)


Agreed, WF_MIGRATE looks better. and "move under CONFIG_SMP" is probably
correct ;)

I still think it makes sense to move task_cpu(p) from try_to_wake_up() to
ttwu_stat(), just because it looks confusing. But this is very minor,
please forget.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/