Re: [PATCH v2] spi: reorganize drivers
From: Grant Likely
Date: Tue Jun 07 2011 - 13:01:21 EST
On Tue, Jun 07, 2011 at 10:28:29AM +0800, Feng Tang wrote:
> On Tue, 7 Jun 2011 00:49:20 +0800
> Dirk Brandewie <dirk.brandewie@xxxxxxxxx> wrote:
> > On 06/06/2011 09:38 AM, Grant Likely wrote:
> > > On Mon, Jun 6, 2011 at 10:31 AM, Mike
> > > Frysinger<vapier.adi@xxxxxxxxx> wrote:
> > >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote:
> > >>> Sort the SPI makefile and enforce the naming convention spi_*.c
> > >>> for spi drivers.
> > >>
> > >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but
> > >> perhaps those are only for /proc/ status tracking ? worth double
> > >> checking ...
> > >
> > > I just talked with Dirk Brandewie, who has a major rewrite to the
> > > topcliff spi driver. I'll let him comment on whether or not
> > > changing KBUILD_MODNAME will cause any problems.
> > >
> > My changes are to the designware driver :-) I will get my patches
> > re-based onto the spi-next branch and see if there any issues.
> If there is major rewrite to the dw_spi driver, please submit to this
> list, as it is used by many devices out there and needs a broad review
That is always the requirement. I'm not going to pick up anything
that hasn't been posted for review, and Dirk is currently working on
getting his patch posted.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/