Re: [PATCH] x86: Fix sys_call_table type in asm/syscall.h
From: Ingo Molnar
Date: Wed Jun 08 2011 - 04:25:20 EST
* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > There's an obvious problem with this patch, please fix it and resend.
>
> Nothing obvious to me. Can you be more specific?
Sure, a trivial git grep of the sys_call_ptr_t typedef you added to
syscall.h shows:
~/tip> git grep sys_call_ptr_t
arch/um/sys-x86_64/syscall_table.c:typedef void (*sys_call_ptr_t)(void);
arch/x86/include/asm/syscall.h:typedef void (*sys_call_ptr_t)(void);
arch/x86/kernel/syscall_64.c:typedef void (*sys_call_ptr_t)(void);
So you've now added a third typedef in addition to the two existing
ones. We obivously only want one in the kernel - the one you added to
the header file.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/