Re: [PATCH 1/3] x86: Readd asmregparm

From: Pekka Enberg
Date: Wed Jun 08 2011 - 07:58:04 EST


Hi Andi,

On Wed, Jun 8, 2011 at 11:37 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>> That's a totally useless changelog (you are deliberately hiding
>> information again) so the series is obviously not acceptable.
>> Please fix and resend.
>
> I reread it and it seems complete to me. Please be more specific.
>
> If you refer to the followon patchkit - it's not ready for posting
> yet. However I believe these changes are reasonable cleanups that are useful
> on their own. That's why I posted them now.

So from my point of view, none of the changelogs explain why the
changes needed. Now, I'm not an expert on the x86 code so maybe I'm
missing something obvious but to me the only rationale seems to be
that you need it some unspecified follow-up patchkit. HTH.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/