Re: [PATCH 6/10] drivers/char/hw_random/nomadik-rng.c: add missingclk_put

From: Herbert Xu
Date: Wed Jun 08 2011 - 09:01:43 EST


On Wed, Jun 01, 2011 at 12:20:46PM -0500, Matt Mackall wrote:
> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@xxxxxxx>
> >
> > Jump to the end of the function for the clk_disable and clk_put rather than
> > returning directly.
> >
> > A simplified version of the semantic match that finds this problem is as
> > follows: (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @r exists@
> > expression e1,e2;
> > statement S;
> > @@
> >
> > e1 = clk_get@p1(...);
> > ... when != e1 = e2
> > when != clk_put(e1)
> > when any
> > if (...) { ... when != clk_put(e1)
> > when != if (...) { ... clk_put(e1) ... }
> > * return@p3 ...;
> > } else S
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@xxxxxxx>
>
> This one also looks good to me.
>
> Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

Both patches applied. Thanks!
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/