Re: [PATCH] x86: CONFIG_EFI should select CONFIG_RELOCATABLE

[Matthew Garrett]

On Thu, Jun 09, 2011 at 07:37:31AM -0700, H. Peter Anvin wrote:
> On 06/09/2011 07:32 AM, Matthew Garrett wrote:
> >  config EFI
> >  	bool "EFI runtime service support"
> >  	depends on ACPI
> > +	select RELOCATABLE
> >  	---help---
> >  	  This enables the kernel to use EFI runtime services that are
> >  	  available (such as the EFI variable services).
> 
> Can we make this a depends on instead of select?

CONFIG_RELOCATABLE has no dependencies so select should be safe, and 
depends means CONFIG_EFI vanishes until you turn on something that seems 
entirely unrelated. I've no problem with it being depends, but this 
seems friendlier.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/