Re: [PATCH 1/2] efi: Fix argument types for SetVariable()

From: Tony Luck
Date: Thu Jun 09 2011 - 15:03:01 EST


On Mon, Jun 6, 2011 at 12:36 PM, Matthew Garrett <mjg@xxxxxxxxxx> wrote:
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index e376270..0758753 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -168,7 +168,7 @@ typedef efi_status_t efi_get_variable_t (efi_char16_t *name, efi_guid_t *vendor,
>  typedef efi_status_t efi_get_next_variable_t (unsigned long *name_size, efi_char16_t *name,
>                                              efi_guid_t *vendor);
>  typedef efi_status_t efi_set_variable_t (efi_char16_t *name, efi_guid_t *vendor,
> -                                        unsigned long attr, unsigned long data_size,
> +                                        u32 attr, unsigned long data_size,
>                                         void *data);
>  typedef efi_status_t efi_get_next_high_mono_count_t (u32 *count);
>  typedef void efi_reset_system_t (int reset_type, efi_status_t status,

x86 isn't the only user of <linux/efi.h>

Building next-20110609 I see:

arch/ia64/kernel/efi.c:578: warning: assignment from incompatible pointer type
arch/ia64/kernel/efi.c:701: warning: assignment from incompatible pointer type

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/