Re: [PATCH v3 06/12] MFD: twl4030-codec -> twl4030-audio: Rename the driver

From: Arnd Bergmann
Date: Thu Jun 09 2011 - 15:37:53 EST


On Thursday 09 June 2011 15:30:24 Peter Ujfalusi wrote:
> Rename the driver, and header file from twl4030-codec to
> twl4030-audio.
> To avoid breakage change depending drivers at the same time.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> CC: Misael Lopez Cruz <misael.lopez@xxxxxx>
> ---
> drivers/input/misc/Kconfig | 2 +-
> drivers/input/misc/twl4030-vibra.c | 10 +-
> drivers/mfd/Kconfig | 2 +-
> drivers/mfd/Makefile | 2 +-
> drivers/mfd/twl4030-audio.c | 277 +++++++++++++++++++++++++++++++++++
> drivers/mfd/twl4030-codec.c | 278 ------------------------------------
> include/linux/mfd/twl4030-audio.h | 272 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/twl4030-codec.h | 272 -----------------------------------

Better use the -M flag to git-format-patch when moving files, to make it
obvious what has or has not changed, and to reduce the size of the email.

Also, shouldn't this file go into the sound/soc/ directory? It seems that this
is really the device driver, not part of the multi-function layer.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/