Re: [PATCH 8/9] x86/amd-iommu: Search for existind dev_data beforeallocting a new one

[Chris Wright]

* Joerg Roedel (joerg.roedel@xxxxxxx) wrote:
> +static struct iommu_dev_data *search_dev_data(u16 devid)
> +{
> +     struct iommu_dev_data *dev_data;
> +     unsigned long flags;
> +
> +	spin_lock_irqsave(&dev_data_list_lock, flags);
> +	list_for_each_entry(dev_data, &dev_data_list, dev_data_list) {
> +		if (dev_data->devid == devid)

This devid match on a global list is not going to work in a multi-segment
machine.  I guess non-zero segment function would either not exist or go
through swiotlb since it's not supported by hw def'n, so only a concern
for the future (along with the other devid based lookup tables).

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/