Re: [PATCH] ide-cd: signedness warning fix again

From: David Miller
Date: Sat Jun 11 2011 - 18:08:33 EST


From: Connor Hansen <cmdkhh@xxxxxxxxx>
Date: Wed, 1 Jun 2011 22:52:05 -0700

> One of the legit warnings 'make W=3 drivers/ide/ide-cd.c'
> generates is:
> drivers/ide/ide-cd.c: In function ide_cd_do_request
> drivers/ide/ide-cd.c:828:2: warning: conversion to int from \
> unsigned int may change the sign of the result
> drivers/ide/ide-cd.c:833:2: warning: conversion to int from \
> unsigned int may change the sign of the result
>
> nsectors is declared int, should be unsigned int.
>
> blk_rq-sectors() returns unsigned int, and ide_complete_rq
> expects unsigned int as well. Fixes both warnings.
>
> Signed-off-by: Connor Hansen <cmdkhh@xxxxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/