Re: [GIT PULL] Btrfs updates

From: Andi Kleen
Date: Sun Jun 12 2011 - 21:04:22 EST


Chris Mason <chris.mason@xxxxxxxxxx> writes:

> Hi everyone,
>
> The for-linus branch of the btrfs unstable tree:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.git for-linus

>
> Has our current queue of fixes. Josef's is the biggest pile, mostly in
> the allocator. Josef and I both managed to merge his patch to avoid
> mapping the extent buffer if skip_locking was set, git merge is just a
> little too easy sometimes (I double checked the resulting code).

The new in 3.0 btrfs warnings on every build are still there:

fs/btrfs/sysfs.c:76: warning: âbtrfs_root_attrsâ defined but not used
fs/btrfs/sysfs.c:97: warning: âbtrfs_super_attrsâ defined but not used
fs/btrfs/sysfs.c:153: warning: âbtrfs_super_releaseâ defined but not used
fs/btrfs/sysfs.c:160: warning: âbtrfs_root_releaseâ defined but not used

These are not even used inside any ifdef. It's unclear to me: were
these supposed to be used or removed?

Probably better to remove since they seem to be untested, unless
it was a merge error?

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/